-
Notifications
You must be signed in to change notification settings - Fork 3
Dev #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rnarducci
wants to merge
42
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nailing down specifics of implementation, setting up entry and arrays and starting from assigning patients to the triage nurse.
Working on adding tasks/task queue. Figuring out how to make changes flexible to change back for testing. Working on janitor next. Might need to take higher level consideration or diagram of how this priority queueing will look.
Fixed and implemented greeter, triage, and janitor trees. Also found and fixed a bug relating to the CT Queue.
First real demonstration of the new methods. Simplifies the Nurse tree in a massive way.
Most functionality set up in nurse tree. Need to set up last two responsibilities. Also consider drafting a flowchart of task allocations.
General tech set up is good, going to go after the Resident tree next. Complications arising in that I can't completely finish one tree because they have dependencies to others queueing them tasks. Should look good when it is done though.
Set up these three trees, but need to finish the escort/pick up behaviors of the tech and nurse. Then will start working on the radiology tree.
CT is set up, xray can be easily copied from there. Radiology is also simple and should be easily done. Some thought/work needs to be put into setting up the escort behaviors, but that shouldn't be too difficult either.
Need to set up phlebotomist and pharmacist. Then need to bug fix everything.
Need to fix bug with CT and XRay queue being double assigned in CT-thesis and follow-instructions.
Almost got the bugs ironed out. Still having some issues with that last behavior of the nurses and noticing odd moments where tech and nurse will go to Main Entrance for some reason.
Still ironing out some problems. General flow is right, but there are points where nurse or tech goes to Main Entrance for no reason and trying to figure out why.
Previous bug was that certain patient severities were not being removed from simulation completely, messing up task queueing. Noticed small bugs in triage to fix: always pickup from CT 1 location and put 2 patients in one room. After these bugs are resolved, I'd like to quickly implement the x-ray back in, then implement the shift change. From there I will make sure the code is similar throughout the new work before testing.
Fixed Techs going to wrong CT room, need to fix the doubling up bug.
Added CT and XRay, fully functional. Now to add shift changes.
Shift Changes have been added and work well.
Took another pass through trees to make sure they share the same structure. Updated notes.
Looks like I probably made an oopsie in the janitor tree when I did some reformatting. Fixed the bugs.
All the janitor bugs should be gone now.
Made slight edits to Go To behavior to get rid of thrashing. Also deleted some dead code in tech-thesis.
Set up some variables to keep track of ticks for length of stay and waiting time in both new and old implementation. Also added idle time tracker for new tech. Will add it to other agents.
Set up data gathering for new implementation. Now I need to set up old implementation in order to compare.
Added testing variables to old implementation and mostly fixed thrashing there too. (check go-to-responsibility) Patients in old clock out style are not deleting themselves from simulation. Related to added testing code? Also noticed massive, massive slowdown in old implementation.
Modified big arrival file and added floorplans.
No one escorts patients out of simulation if I try to add more techs. Medical agents don't completely leave simulation when they 'clock out'. Did waiting room fix actually work?
Reduced number of patient entries in arrival data. Took out shift change because bug fix is proving too long and difficult.
Finally found the source of the crash. Task wasn't queuing correctly in CT. Also made realization that if I'm going to make task queuing it's own do node, it should be at the top of the behavior tree so it isn't unreachable on occasions.
Reminder to self to investigate data when running on different machine. (tick value) Also reminder to put queue tasks at top of trees universally.
Most of the bugfixing and testing is done here. Need to get a suitable json file set up.
Altered parameter of testing, should be more accurate.
Removed the time added to "idle time" from transit in new implementation.
Granted we might want to halve the number of patients, as it gets pretty crowded after 6 hours with the number of arrivals we have, even with more medical staff.
Editing take time to be same throughout implementations, fixing bugs I noticed, and making output easier to put into my tables.
Has waiting breakdown data and some bugfixes
Adjustments made to more accurately represent these values
Renaming, cleaning up, and moving things around in preparation for project handoff. More pushes to come.
More documentation and notetaking.
Added back emergency patient and a team support, did further documentation, started on priority queuing, and other edits.
✅ Deploy Preview for peaceful-brahmagupta-1fe63e ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all thesis changes, overall refactoring changes, added documentation, and a TUTORIAL.md file.
I might've missed some things to change or document, so just let me know if you catch anything. Otherwise I am satisfied with this branch.